Closed iche033 closed 1 year ago
Merging #520 (2fe5353) into ign-gui6 (eef51bf) will increase coverage by
0.03%
. The diff coverage isn/a
.:exclamation: Current head 2fe5353 differs from pull request most recent head 293703e. Consider uploading reports for the commit 293703e to get more accurate results
@@ Coverage Diff @@
## ign-gui6 #520 +/- ##
============================================
+ Coverage 68.06% 68.10% +0.03%
============================================
Files 39 39
Lines 5327 5327
============================================
+ Hits 3626 3628 +2
+ Misses 1701 1699 -2
see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
From reading https://doc.qt.io/qt-5/location-plugin-mapboxgl.html, it says
Both Mapbox geo services plugins require an access token to access map styles and tiles hosted by Mapbox.
and the documentation on mabpoxgl.access_token
says
Access token provided by Mapbox. The token can also be specified using the environment variable MAPBOX_ACCESS_TOKEN, but if also set using a plugin parameter, then this last one will have the precedence over the environment variable. When not set, a development token will be used by default. The development token is subject to the Mapbox Terms of Services and must not be used in production. This property has no effect on styles hosted outside the Mapbox servers.
So it's not clear to me if we're allowed to use it.
Also, when the box is moved using the transform tool, the GUI freezes up still :(
hmm ok closing as it's not clear if we can use the plugin and it also does not completely fix the issue.
🦟 Bug fix
Fixes https://github.com/gazebosim/gz-gui/issues/482
Summary
Using the
osm
map plugin in the NavSat gui plugin seems to cause the window to freeze / crash. Switched to usemapboxgl
instead.Now it works for me:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.