Closed scpeters closed 1 year ago
Merging #531 (a85e581) into main (82aa5b1) will decrease coverage by
0.02%
. Report is 2 commits behind head on main. The diff coverage isn/a
.:exclamation: Current head a85e581 differs from pull request most recent head 5512c92. Consider uploading reports for the commit 5512c92 to get more accurate results
@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 70.09% 70.07% -0.02%
==========================================
Files 46 46
Lines 5062 5062
==========================================
- Hits 3548 3547 -1
- Misses 1514 1515 +1
Files Changed | Coverage Δ | |
---|---|---|
src/plugins/world_control/WorldControl.cc | 72.60% <ø> (ø) |
@scpeters can you look into why ci is failing?
CI seems to be failing already on the main
branch
I ran the tests locally on my Mac laptop and they all passed. I'm guessing there are issues with the display / GPU in the cloud CI machines
🎉 New feature
Changes a default behavior to resolve a TODO comment
Summary
I noticed a comment in WorldControl.cc (originally from https://github.com/gazebosim/gz-gui/pull/306) suggesting that a default behavior should be changed in gz-gui7, but that has already been released, so I'm proposing the change for gz-gui8. The change will cause events to be used by default instead of services. I am not familiar with any of the context for this but have opened a draft pull request to promote discussion.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.