gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.

https://gazebosim.org

Apache License 2.0

67 stars 39 forks source link

Remove ignition #556

Closed nkoenig closed 10 months ago

nkoenig commented 11 months ago

🎉 New feature

Remove ignition

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

nkoenig commented 11 months ago

5844641

I found a few more places:

https://github.com/gazebosim/gz-gui/blob/main/tutorials/01_install.md

https://github.com/gazebosim/gz-gui/blob/5bbfc6306cb6466aa659d6325d84311a06470ed8/include/gz/gui/qml/qmldir#L9-L11

https://github.com/gazebosim/gz-gui/blob/5bbfc6306cb6466aa659d6325d84311a06470ed8/examples/plugin/gz_components/GzComponents.qml#L43-L50

Are we leaving this? https://github.com/gazebosim/gz-gui/blob/6851f0453613fd8079e8c3378a7d94d3d847fcf8/src/Application.cc#L61-L63

https://github.com/gazebosim/gz-gui/blob/6851f0453613fd8079e8c3378a7d94d3d847fcf8/src/Plugin.cc#L75

https://github.com/gazebosim/gz-gui/blob/5bbfc6306cb6466aa659d6325d84311a06470ed8/src/plugins/marker_manager/MarkerManager.cc#L356

Remvoed in 5844641

mjcarroll commented 10 months ago

I think there are still a few references to pluginPathEnvDeprecated judging by current CI

codecov[bot] commented 10 months ago

Codecov Report

Merging #556 (7e03bab) into main (974957f) will increase coverage by 0.08%. The diff coverage is 100.00%.

:exclamation: Current head 7e03bab differs from pull request most recent head 1940106. Consider uploading reports for the commit 1940106 to get more accurate results

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   68.05%   68.14%   +0.08%     
==========================================
  Files          38       38              
  Lines        5394     5362      -32     
==========================================
- Hits         3671     3654      -17     
+ Misses       1723     1708      -15

Files Changed	Coverage Δ
src/Plugin.cc	`83.19% <ø> (+0.86%)`	:arrow_up:
src/gz.cc	`42.00% <ø> (+1.61%)`	:arrow_up:
src/Application.cc	`84.50% <100.00%> (+0.46%)`	:arrow_up:
src/MainWindow.cc	`95.68% <100.00%> (+0.58%)`	:arrow_up:
src/plugins/marker_manager/MarkerManager.cc	`58.82% <100.00%> (ø)`
src/plugins/minimal_scene/MinimalScene.cc	`57.73% <100.00%> (+0.06%)`	:arrow_up:

iche033 commented 10 months ago

I think there are still a few references to pluginPathEnvDeprecated judging by current CI

I think 5fbbcf2 should do it