search

gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Fix rendering tests #561

Closed iche033 closed 10 months ago

iche033 commented 10 months ago

🦟 Bug fix

Targeted at https://github.com/gazebosim/gz-gui/pull/429

Summary

The tests below are still failing on Jammy github actions in https://github.com/gazebosim/gz-gui/pull/429:

The failing tests were supposed to be fixed by https://github.com/gazebosim/gz-gui/pull/535 but for some reason they are now happening again.

The "fix" is more of a workaround. The main change is to not unload the render engine on exit which is what's causing the segfault in these 2 tests. It's safe to remove the DestroyScene call in the tests as that's taken care of by the minimal scene plugin. The tests do not fail on other CI builds and I'm also not able to reproduce them locally.

We could either get this in to make CI green or spend more time finding the root cause of the problem.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

Merging #561 (a091613) into fix_tests (e655d40) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a091613 differs from pull request most recent head 24b3c1c. Consider uploading reports for the commit 24b3c1c to get more accurate results

@@            Coverage Diff             @@
##           fix_tests     #561   +/-   ##
==========================================
  Coverage      70.91%   70.91%           
==========================================
  Files             45       45           
  Lines           4941     4941           
==========================================
  Hits            3504     3504           
  Misses          1437     1437
iche033 commented 10 months ago

Do you think it's worth figuring out why unloading the engine fails?

I created https://github.com/gazebosim/gz-gui/issues/565 for this. I'll look into it as a background task.