gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Fix plugin filter on Windows #567

Closed peci1 closed 8 months ago

peci1 commented 10 months ago

🦟 Bug fix

Summary

On Windows, the plugin combobox in GUI was always empty (both in GUI alone and in GZ GUI). This PR fixes it.

It seems to me it 'd be beneficial if this logic was extracted as helper functions to gz-plugin.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

Merging #567 (a4cef4a) into gz-gui8 (e898137) will decrease coverage by 1.96%. The diff coverage is 100.00%.

:exclamation: Current head a4cef4a differs from pull request most recent head 15ee40f. Consider uploading reports for the commit 15ee40f to get more accurate results

@@             Coverage Diff             @@
##           gz-gui8     #567      +/-   ##
===========================================
- Coverage    70.06%   68.11%   -1.96%     
===========================================
  Files           39       39              
  Lines         5359     5375      +16     
===========================================
- Hits          3755     3661      -94     
- Misses        1604     1714     +110     
Files Coverage Δ
src/Application.cc 84.21% <100.00%> (+0.07%) :arrow_up:
src/MainWindow.cc 95.69% <100.00%> (+0.01%) :arrow_up:

... and 33 files with indirect coverage changes

mjcarroll commented 8 months ago

@osrf-jenkins retest this please