Closed peci1 closed 8 months ago
Merging #567 (a4cef4a) into gz-gui8 (e898137) will decrease coverage by
1.96%
. The diff coverage is100.00%
.:exclamation: Current head a4cef4a differs from pull request most recent head 15ee40f. Consider uploading reports for the commit 15ee40f to get more accurate results
@@ Coverage Diff @@
## gz-gui8 #567 +/- ##
===========================================
- Coverage 70.06% 68.11% -1.96%
===========================================
Files 39 39
Lines 5359 5375 +16
===========================================
- Hits 3755 3661 -94
- Misses 1604 1714 +110
Files | Coverage Δ | |
---|---|---|
src/Application.cc | 84.21% <100.00%> (+0.07%) |
:arrow_up: |
src/MainWindow.cc | 95.69% <100.00%> (+0.01%) |
:arrow_up: |
@osrf-jenkins retest this please
🦟 Bug fix
Summary
On Windows, the plugin combobox in GUI was always empty (both in GUI alone and in GZ GUI). This PR fixes it.
It seems to me it 'd be beneficial if this logic was extracted as helper functions to gz-plugin.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.