gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Changes ignition for gz in tutorial commands #570

Closed Voldivh closed 9 months ago

Voldivh commented 9 months ago

🦟 Bug fix

Fixes https://github.com/gazebosim/gazebo_test_cases/issues/564

Summary

Changes the use of ignition for gz in tutorial commands.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 9 months ago

Codecov Report

Merging #570 (5a5a54c) into gz-gui8 (20616c1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5a5a54c differs from pull request most recent head 15df2c9. Consider uploading reports for the commit 15df2c9 to get more accurate results

@@           Coverage Diff            @@
##           gz-gui8     #570   +/-   ##
========================================
  Coverage    68.10%   68.10%           
========================================
  Files           38       38           
  Lines         5367     5367           
========================================
  Hits          3655     3655           
  Misses        1712     1712           
jennuine commented 9 months ago

Can you sign commits please: https://github.com/gazebosim/gz-gui/pull/570/checks?check_run_id=16804603853

For future, when making commits, you can do git commit -sm "commit message" to add the signoff to your commits.

Voldivh commented 9 months ago

Can you sign commits please: https://github.com/gazebosim/gz-gui/pull/570/checks?check_run_id=16804603853

For future, when making commits, you can do git commit -sm "commit message" to add the signoff to your commits.

Sure thing. I'm not sure why this is happening, I usually just do git commit -s -m "commit message"

jennuine commented 9 months ago

I'm not sure why this is happening, I usually just do git commit -s -m "commit message"

That works too. I believe your first and last commit were signed but the two middle ones weren't. If you like, there is a way to set this up automatically so you don't always have to remember -s: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Voldivh commented 9 months ago

I'm not sure why this is happening, I usually just do git commit -s -m "commit message"

That works too. I believe your first and last commit were signed but the two middle ones weren't. If you like, there is a way to set this up automatically so you don't always have to remember -s: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Thanks Jenn, I'll take a look into it. Could have easily missed a couple by accident :D