gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Fix crash when starting Topic Viewer #574

Closed azeey closed 9 months ago

azeey commented 9 months ago

🦟 Bug fix

Summary

Starting the Topic Viewer in gz-sim causes a crash for me. The crash only seems to happen in one of my machines, so it might not be easy to reproduce.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 9 months ago

Codecov Report

Merging #574 (8d0515a) into gz-gui8 (c01d327) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 8d0515a differs from pull request most recent head c517328. Consider uploading reports for the commit c517328 to get more accurate results

@@             Coverage Diff             @@
##           gz-gui8     #574      +/-   ##
===========================================
+ Coverage    68.10%   68.11%   +0.01%     
===========================================
  Files           38       38              
  Lines         5367     5369       +2     
===========================================
+ Hits          3655     3657       +2     
  Misses        1712     1712              
Files Changed Coverage Δ
src/plugins/topic_viewer/TopicViewer.cc 80.89% <100.00%> (+0.24%) :arrow_up: