gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
74 stars 43 forks source link

Use fully-qualified message names to avoid deprecation warning #575

Closed mjcarroll closed 1 year ago

mjcarroll commented 1 year ago

gz-msgs now expects the factory to get fully qualified message names, and only provides the short name functionality with deprecation warnings.

This avoids the deprecation warnings, and should make message population more robust with 3rd-party messages.

codecov[bot] commented 1 year ago

Codecov Report

Merging #575 (a9fd7ab) into gz-gui8 (63ed9ea) will decrease coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head a9fd7ab differs from pull request most recent head dfe684f. Consider uploading reports for the commit dfe684f to get more accurate results

@@             Coverage Diff             @@
##           gz-gui8     #575      +/-   ##
===========================================
- Coverage    68.11%   68.07%   -0.04%     
===========================================
  Files           38       38              
  Lines         5369     5369              
===========================================
- Hits          3657     3655       -2     
- Misses        1712     1714       +2     
Files Changed Coverage Δ
src/plugins/topic_viewer/TopicViewer.cc 79.61% <100.00%> (-1.28%) :arrow_down: