Use gz::utils::ImplPtr as much as possible

mjcarroll commented 9 months ago

This changes the rest of our std::unique_ptr implementations over to gz::utils::ImplPtr.

codecov[bot] commented 9 months ago

Codecov Report

Merging #583 (0335516) into main (838f6bc) will decrease coverage by 2.00%. Report is 1 commits behind head on main. The diff coverage is 88.60%.

:exclamation: Current head 0335516 differs from pull request most recent head ad66724. Consider uploading reports for the commit ad66724 to get more accurate results

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   70.06%   68.07%   -2.00%     
==========================================
  Files          39       38       -1     
  Lines        5359     5369      +10     
==========================================
- Hits         3755     3655     -100     
- Misses       1604     1714     +110

Files	Coverage Δ
include/gz/gui/GuiEvents.hh	`100.00% <100.00%> (ø)`
include/gz/gui/MainWindow.hh	`100.00% <100.00%> (ø)`
include/gz/gui/Plugin.hh	`100.00% <100.00%> (ø)`
src/Application.cc	`84.09% <100.00%> (-0.04%)`	:arrow_down:
src/Conversions.cc	`95.18% <100.00%> (ø)`
src/Dialog.cc	`100.00% <ø> (ø)`
src/DragDropModel.cc	`100.00% <ø> (ø)`
src/GuiEvents.cc	`100.00% <ø> (ø)`
src/MainWindow.cc	`95.68% <ø> (+<0.01%)`	:arrow_up:
src/PlottingInterface.cc	`56.02% <ø> (-0.05%)`	:arrow_down:
... and 22 more

... and 5 files with indirect coverage changes

mjcarroll commented 7 months ago

Should be fixed by https://github.com/gazebosim/gz-common/pull/553

mjcarroll commented 7 months ago

@osrf-jenkins retest this please

mjcarroll commented 7 months ago

@ahcorde I think we are good here now

gazebosim / gz-gui

Use gz::utils::ImplPtr as much as possible #583

Codecov Report