gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
74 stars 43 forks source link

Enable HIDE_SYMBOLS_BY_DEFAULT + patches #600

Closed j-rivero closed 10 months ago

j-rivero commented 10 months ago

🎉 New feature

Part of https://github.com/gazebosim/gz-cmake/pull/392 and https://github.com/gazebosim/gz-cmake/issues/166.

Summary

The PR enables the HIDE_SYMBOLS_BY_DEFAULT option and patch the failures found during the build on Linux.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (352e726) 70.14% compared to head (8ce0780) 70.14%.

:exclamation: Current head 8ce0780 differs from pull request most recent head 9ba8a3c. Consider uploading reports for the commit 9ba8a3c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #600 +/- ## ======================================= Coverage 70.14% 70.14% ======================================= Files 38 38 Lines 5343 5343 ======================================= Hits 3748 3748 Misses 1595 1595 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

j-rivero commented 10 months ago

This is now disabled ignition_gui-ci-pr_any-homebrew-amd64, check gz_gui-ci-pr_any-homebrew-amd64

mjcarroll commented 10 months ago

Some Qt/Windows interactions causing the build to fail:

C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc(25,1): warning C4273: 'gz::gui::TestHelper::TestHelper': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.hh(44,11): message : see previous definition of '{ctor}' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(59,1): warning C4273: 'gz::gui::TestHelper::qt_static_metacall': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'qt_static_metacall' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): warning C4273: 'staticMetaObject': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'public: static QMetaObject const gz::gui::TestHelper::staticMetaObject' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): error C2491: 'gz::gui::TestHelper::staticMetaObject': definition of dllimport static data member not allowed [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
j-rivero commented 10 months ago

Closing this one in favor of #601