Closed j-rivero closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
352e726
) 70.14% compared to head (8ce0780
) 70.14%.:exclamation: Current head 8ce0780 differs from pull request most recent head 9ba8a3c. Consider uploading reports for the commit 9ba8a3c to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is now disabled ignition_gui-ci-pr_any-homebrew-amd64
, check gz_gui-ci-pr_any-homebrew-amd64
Some Qt/Windows interactions causing the build to fail:
C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc(25,1): warning C4273: 'gz::gui::TestHelper::TestHelper': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.hh(44,11): message : see previous definition of '{ctor}' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(59,1): warning C4273: 'gz::gui::TestHelper::qt_static_metacall': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'qt_static_metacall' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): warning C4273: 'staticMetaObject': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'public: static QMetaObject const gz::gui::TestHelper::staticMetaObject' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): error C2491: 'gz::gui::TestHelper::staticMetaObject': definition of dllimport static data member not allowed [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]
Closing this one in favor of #601
🎉 New feature
Part of https://github.com/gazebosim/gz-cmake/pull/392 and https://github.com/gazebosim/gz-cmake/issues/166.
Summary
The PR enables the
HIDE_SYMBOLS_BY_DEFAULT
option and patch the failures found during the build on Linux.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.