search

gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
66 stars 39 forks source link

Adding cone primitives. #621

Closed bperseghetti closed 2 weeks ago

bperseghetti commented 1 month ago

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters commented 3 weeks ago

do you mind merging this branch with main to restart CI?

scpeters commented 3 weeks ago

optional: we could update the marker example to draw a cone shape

bperseghetti commented 3 weeks ago

@scpeters

do you mind merging this branch with main to restart CI?

rebased on main and force-pushed

optional: we could update the marker example to draw a cone shape

Yeah, I suppose we could do that, although I might prefer to add anything else in a follow on PR just so I can limit the scope of this and get it in as fast as possible as we all really need this in harmonic and that still requires a backport.

bperseghetti commented 3 weeks ago

@scpeters @azeey all good for this getting merged? Any way that we can get the nightly for this also updated so I can get the https://github.com/gazebosim/gz-sim/pull/2410 in as well? Then I can start the backport process.