gazebosim / gz-launch

Run and manage programs and plugins.
https://gazebosim.org
Apache License 2.0
12 stars 17 forks source link

GZ_LAUNCH_VERSION_NAMESPACE not defined? #217

Open traversaro opened 1 year ago

traversaro commented 1 year ago

Environment

Description

It seems that this library uses a GZ_LAUNCH_VERSION_NAMESPACE macro, but this macro is not defined in config.hh.

Steps to reproduce

Inspect the code and see that GZ_LAUNCH_VERSION_NAMESPACE is not defined.

1. 2. 3.

Output

At this point, we can't define GZ_LAUNCH_VERSION_NAMESPACE for gz-launch 6, otherwise we would create an ABI break. However we should remember to define it for gz-launch 7.

azeey commented 1 year ago

Good catch! We could add this to the main branch now.