Closed chapulina closed 2 years ago
Merging #281 (831525e) into main (0a09d3d) will decrease coverage by
0.97%
. The diff coverage is62.85%
.
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 85.59% 84.62% -0.98%
==========================================
Files 10 10
Lines 972 995 +23
==========================================
+ Hits 832 842 +10
- Misses 140 153 +13
Impacted Files | Coverage ฮ | |
---|---|---|
include/gz/msgs/Factory.hh | 66.66% <60.00%> (-33.34%) |
:arrow_down: |
src/Factory.cc | 81.18% <64.00%> (-7.19%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
ฮ = absolute <relative> (impact)
,รธ = not affected
,? = missing data
Powered by Codecov. Last update 0a09d3d...831525e. Read the comment docs.
Summary
Accept
ignition
messages onFactory::New
, print warning and returngz
equivalent.Test it
Try sending an
ignition
message, see that it's sent, and a warning is printed.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ๐ธ