gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
24 stars 47 forks source link

[ign to gz] Factory::New accept ignition with warning #281

Closed chapulina closed 2 years ago

chapulina commented 2 years ago

Summary

Accept ignition messages on Factory::New, print warning and return gz equivalent.

Test it

Try sending an ignition message, see that it's sent, and a warning is printed.

ign topic -t /model/joint/thruster4_joint/cmd_thrust -m ignition.msgs.Double -p 'data: 5'
Trying to create deprecated message type [ignition.msgs.Double]. Use [gz.msgs.Double] instead.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ

codecov[bot] commented 2 years ago

Codecov Report

Merging #281 (831525e) into main (0a09d3d) will decrease coverage by 0.97%. The diff coverage is 62.85%.

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   85.59%   84.62%   -0.98%     
==========================================
  Files          10       10              
  Lines         972      995      +23     
==========================================
+ Hits          832      842      +10     
- Misses        140      153      +13     
Impacted Files Coverage ฮ”
include/gz/msgs/Factory.hh 66.66% <60.00%> (-33.34%) :arrow_down:
src/Factory.cc 81.18% <64.00%> (-7.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data Powered by Codecov. Last update 0a09d3d...831525e. Read the comment docs.