Closed scpeters closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
gz-msgs9@4294c64
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## gz-msgs9 #301 +/- ##
===========================================
Coverage ? 95.41%
===========================================
Files ? 10
Lines ? 1026
Branches ? 0
===========================================
Hits ? 979
Misses ? 47
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I've also removed the include/ignition/msgs/test_config.h
redirection header per #302 and a discussion with @methylDragon, which should fix the abi-checker build
ABI checker is still failing with the same issue. It might be from a dirty workspace, I'm going to clear the workspace and rerun the job.
ABI checker is still failing with the same issue. It might be from a dirty workspace, I'm going to clear the workspace and rerun the job.
I think the ABI checking is failing on the target branch; I think the job won't succeed until this has been merged to gz-msgs9
ABI checker is still failing with the same issue. It might be from a dirty workspace, I'm going to clear the workspace and rerun the job.
I think the ABI checking is failing on the target branch; I think the job won't succeed until this has been merged to
gz-msgs9
I merged https://github.com/gazebosim/gz-msgs/pull/301/commits/104ea78892cb639d82dbdc60230ac40454d7f244 directly to gz-msgs9
in #303, so I expect CI to be fixed now
🦟 Bug fix
Fixes failing test
Summary
There is a portion of the
UNIT_gz_TEST
that is still calling theign
command, but that was removed from gz-tools2, so the test is failing. Just callgz
instead.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.