Closed ahcorde closed 1 year ago
Merging #365 (33a5f57) into main (47df55c) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 33a5f57 differs from pull request most recent head 88d7107. Consider uploading reports for the commit 88d7107 to get more accurate results
@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 9 9
Lines 1045 1045
=======================================
Hits 1013 1013
Misses 32 32
One question I actually had about this when looking over all of the messages. We typically use two messages for each sensor, one with the Sensor
suffix to follow the SDF representation of that sensor, and then a second message that holds the actual generated data. It seems that the AirSpeedSensor
doesn't follow this convention, sensor data is stored in the Sensor
message itself?
One question I actually had about this when looking over all of the messages. We typically use two messages for each sensor, one with the
Sensor
suffix to follow the SDF representation of that sensor, and then a second message that holds the actual generated data. It seems that theAirSpeedSensor
doesn't follow this convention, sensor data is stored in theSensor
message itself?
See this comment https://github.com/gazebosim/gz-sim/pull/2054#issuecomment-1677330786
🎉 New feature
Summary
Added AirSpeedSensor msgs to Sensor msg
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.