gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
23 stars 47 forks source link

Harmonic: TODOs related with the migration from `ign` to `gz` #366

Closed ahcorde closed 1 year ago

ahcorde commented 1 year ago

πŸŽ‰ New feature

Summary

TODOS related with the migration from ign to gz

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 1 year ago

Codecov Report

Merging #366 (c182dd8) into gz-msgs10 (f41e1e2) will decrease coverage by 1.43%. The diff coverage is 100.00%.

:exclamation: Current head c182dd8 differs from pull request most recent head 210e5ac. Consider uploading reports for the commit 210e5ac to get more accurate results

@@              Coverage Diff              @@
##           gz-msgs10     #366      +/-   ##
=============================================
- Coverage      97.21%   95.79%   -1.43%     
=============================================
  Files             27        9      -18     
  Lines           1150     1070      -80     
=============================================
- Hits            1118     1025      -93     
- Misses            32       45      +13     
Files Changed Coverage Ξ”
src/Factory.cc 82.69% <100.00%> (ΓΈ)

... and 35 files with indirect coverage changes

azeey commented 1 year ago

Can you resolve conflicts?

iche033 commented 1 year ago

looks like the files with conflicts in src were removed and the bzl file diff is probably out-of-date so we may not need this PR anymore

mjcarroll commented 1 year ago

bzl file diff is probably out-of-date

That got dropped here, maybe not picked up in a forward port yet? https://github.com/gazebosim/gz-msgs/pull/347

iche033 commented 1 year ago

Just merged from gz-msgs10 and now we have 0 changes :)

iche033 commented 1 year ago

Closing this PR