gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
23 stars 47 forks source link

Ensure that tests pass fine with GZ_RELOCATABLE_INSTALL option enabled #394

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

🦟 Bug fix

Fix tests when GZ_RELOCATABLE_INSTALL CMake option is enabled and the operating system is Windows or Linux without the install step being run.

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 1 year ago

Codecov Report

Merging #394 (4a1a615) into gz-msgs10 (3d60486) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4a1a615 differs from pull request most recent head 448d107. Consider uploading reports for the commit 448d107 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #394   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           
mjcarroll commented 1 year ago

Friendly ping @traversaro, if this is ready I can review.

traversaro commented 1 year ago

Friendly ping @traversaro, if this is ready I can review.

Ok! For the DCO should I rebased on the latest gz-msgs10 dropping the merge and adding the DCO just on the latest rebased commit?

mjcarroll commented 1 year ago

Ok! For the DCO should I rebased on the latest gz-msgs10 dropping the merge and adding the DCO just on the latest rebased commit?

Rebasing generally fixes it, but I can also override it as I have done here, since it's the merge commit causing the issue.