Open henrykotze opened 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
29cfe33
) 95.57% compared to head (db9a31f
) 95.57%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Friendly ping @henrykotze
Will be looking into this soon. :+1: Thanks for the ping, I was on an extended holiday.
@caguero Thanks for showing this to me.
I could definitely extend my code to account for the 3D vector, since the sensor would be more useful to other applications it seems. There does exist 3D airflow sensors (they are though much less than those of 2D, but it makes sense to account for future use-case)
I would also stick to my naming scheme since an anemometer measures the magnitude of a 2D wind velocity, so i think Airflow is a more applicable name for the sensor.
Let me know what you think and how I should proceed.
From what I can see, each sensor has its own message, since they include the SensorNoise type in it. Also I think there exist the possibility that the message would be extended, since these airflow sensor provides more information about environment such as temperature and humidity.
Let me know how I should proceed
I think a single 3D vector should capture your direction and speed (magnitude).
:+1: , so for clarity: Add the 3d vector and use the standard vector3d message?
π , so for clarity: Add the 3d vector and use the standard vector3d message?
π
πΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈ
π New feature
Summary
This adds an airflow sensor. These sensors are generally used to measure wind and are ultrasonic devices, measuring the airflow speed and direction using the Doppler effect.
Here is some use cases of such sensors from a manufacturer sensor which we have used.
https://fttechnologies.com/case-studies.
This is part of a larger plan to support an airflow sensor in PX4. @dagar
Test it
Test are added to ensure correct use.
Some things to consider
There exist airflow/wind sensors which provides a 3D vector of the airflow its measuring. So I can see a later addition of adding more properties to the messages, however I have only experience with the 2D sensor, and these properties are the most relevant to them