gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
21 stars 45 forks source link

Conditionally use cmake_path on cmake < 3.20 #424

Closed mjcarroll closed 8 months ago

mjcarroll commented 8 months ago

🦟 Bug fix

Fixes #423

Summary

This will conditionally use cmake_path if it is available, otherwise use multiple CMake functions to get the same behavior. Note that on the forward port, we can drop the alternate path (https://github.com/gazebosim/gz-cmake/issues/350)

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ea68ca0) 97.67% compared to head (dd2ef92) 97.67%. Report is 1 commits behind head on gz-msgs10.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-msgs10 #424 +/- ## ========================================== Coverage 97.67% 97.67% ========================================== Files 27 27 Lines 1163 1163 ========================================== Hits 1136 1136 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.