Closed bperseghetti closed 3 weeks ago
Attention: Patch coverage is 20.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 97.86%. Comparing base (
1939fb0
) to head (fda8ba8
). Report is 11 commits behind head on gz-msgs10.:exclamation: Current head fda8ba8 differs from pull request most recent head 34eab63
Please upload reports for the commit 34eab63 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
core/include/gz/msgs/convert/GeometryType.hh | 20.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@azeey @caguero @ahcorde this is now the backport that needs to get in and be released.
🦟 Bug fix
Summary
This helps add the missing cone geometry for primitive/basic parametric shapes:
And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:
Associated PRs:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.