gazebosim / gz-msgs

Messages for Gazebo robot simulation.
https://gazebosim.org
Apache License 2.0
21 stars 43 forks source link

Add Cone as a primitive parametric shape. #441

Closed bperseghetti closed 3 weeks ago

bperseghetti commented 1 month ago

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (1939fb0) to head (fda8ba8). Report is 11 commits behind head on gz-msgs10.

:exclamation: Current head fda8ba8 differs from pull request most recent head 34eab63

Please upload reports for the commit 34eab63 to get more accurate results.

Files Patch % Lines
core/include/gz/msgs/convert/GeometryType.hh 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-msgs10 #441 +/- ## ============================================= - Coverage 98.19% 97.86% -0.34% ============================================= Files 27 27 Lines 1166 1171 +5 ============================================= + Hits 1145 1146 +1 - Misses 21 25 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bperseghetti commented 3 weeks ago

@azeey @caguero @ahcorde this is now the backport that needs to get in and be released.