gazebosim / gz-mujoco

25 stars 4 forks source link

SDFormat->MJCF: Handle relative resource paths #107

Closed azeey closed 1 year ago

azeey commented 1 year ago

🦟 Bug fix

Summary

This fixes an exception thrown when an input SDFormat file has resources that use relative URIs and the converter is run from a directory where the relative path doesn't point to the desired file.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

codecov[bot] commented 1 year ago

Codecov Report

Merging #107 (6201715) into main (e353ba2) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   95.20%   95.29%   +0.09%     
==========================================
  Files          24       24              
  Lines        1168     1170       +2     
==========================================
+ Hits         1112     1115       +3     
+ Misses         56       55       -1     
Impacted Files Coverage Δ
...sdformat_mjcf/sdformat_to_mjcf/sdformat_to_mjcf.py 100.00% <100.00%> (ø)
...ormat_mjcf/sdformat_to_mjcf/converters/geometry.py 94.20% <0.00%> (+1.44%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.