gazebosim / gz-mujoco

28 stars 4 forks source link

Use MJCF default values for gravity, magnetic, and wind when not set #109

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

We weren't using the correct MJCF default values for gravity, magnetic, and wind. The default for wind matches the SDFormat default so it wasn't an issue, but the other elements, especially, magnetic, had different values.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (0b793b4) into main (f644622) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          24       24           
  Lines        1168     1168           
=======================================
  Hits         1112     1112           
  Misses         56       56           
Impacted Files Coverage Δ
...sdformat_mjcf/mjcf_to_sdformat/converters/world.py 97.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.