gazebosim / gz-mujoco

28 stars 4 forks source link

SDFormat -> MJCF: Set mesh scale #111

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

The mesh scale was not being set when converting from SDFormat to MJCF.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ

codecov[bot] commented 2 years ago

Codecov Report

Merging #111 (29f21ee) into main (b535b80) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   95.29%   95.30%           
=======================================
  Files          24       24           
  Lines        1170     1171    +1     
=======================================
+ Hits         1115     1116    +1     
  Misses         55       55           
Impacted Files Coverage Ξ”
...ormat_mjcf/sdformat_to_mjcf/converters/geometry.py 94.28% <100.00%> (+0.08%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.