Closed ahcorde closed 2 years ago
it requires https://github.com/gazebosim/sdformat/pull/1013
Merging #19 (ebc57d2) into main (135d294) will increase coverage by
2.32%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 89.41% 91.73% +2.32%
==========================================
Files 6 8 +2
Lines 189 230 +41
==========================================
+ Hits 169 211 +42
+ Misses 20 19 -1
Impacted Files | Coverage Δ | |
---|---|---|
sdformat_mjcf/sdformat_mjcf/converters/light.py | 100.00% <100.00%> (ø) |
|
sdformat_mjcf/sdformat_mjcf/converters/link.py | 100.00% <0.00%> (ø) |
|
sdformat_mjcf/sdformat_mjcf/sdf_utils.py | 68.75% <0.00%> (+16.57%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 135d294...ebc57d2. Read the comment docs.
🎉 New feature
Summary
it requires https://github.com/gazebosim/sdformat/pull/989
Related with this issue https://github.com/gazebosim/gz-mujoco/issues/11
This PR adds lights to links
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.