gazebosim / gz-mujoco

25 stars 4 forks source link

Add code coverage #22

Closed azeey closed 2 years ago

azeey commented 2 years ago

Summary

Run code coverage and report to codecov

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@80586b0). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   83.33%           
=======================================
  Files           ?        4           
  Lines           ?       72           
  Branches        ?        0           
=======================================
  Hits            ?       60           
  Misses          ?       12           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80586b0...ebe22a5. Read the comment docs.

azeey commented 2 years ago

I can't see the codecov comment

Yeah, I followed https://about.codecov.io/blog/python-code-coverage-using-github-actions-and-codecov/, but it didn't mention that the default output of coverage is not supported by codecov. So I had to add xml generation in https://github.com/gazebosim/gz-mujoco/pull/22/commits/ebe22a544e21fe1dce1faa5f131ca8b2a43e4bb8