search

gazebosim / gz-mujoco

25 stars 4 forks source link

MJCF to SDF: Add primitive geometry conversion #26

Closed ahcorde closed 2 years ago

ahcorde commented 2 years ago

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (fe76768) into main (7f0a306) will increase coverage by 0.15%. The diff coverage is 97.41%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   96.94%   97.09%   +0.15%     
==========================================
  Files          11       14       +3     
  Lines         327      482     +155     
==========================================
+ Hits          317      468     +151     
- Misses         10       14       +4
Impacted Files Coverage Δ
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 94.11% <94.11%> (ø)
...o_sdformat/mjcf_to_sdformat/converters/geometry.py 95.94% <95.94%> (ø)
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f0a306...fe76768. Read the comment docs.

ahcorde commented 2 years ago

@azeey Added fromto to capsule and cylinder

ahcorde commented 2 years ago

@azeey I forgot to add the link the visual/collision poses

https://github.com/gazebosim/gz-mujoco/blob/40148462713bdbba5fa3ba236d57bf8c24596e61/mjcf_to_sdformat/mjcf_to_sdformat/converters/link.py#L99-L128

but it's done and tested