gazebosim / gz-mujoco

25 stars 4 forks source link

MJCF to SDF: Added geometry defaults #43

Closed ahcorde closed 2 years ago

ahcorde commented 2 years ago

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

You can define some defaul values in mujoco:

   <default>
     <geom type="capsule" mass="1"/>
   </default>

This PR allows to read these values and set them

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #43 (a78b7e2) into main (590822c) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a78b7e2 differs from pull request most recent head 805f8ec. Consider uploading reports for the commit 805f8ec to get more accurate results

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          16       16           
  Lines         653      653           
=======================================
  Hits          639      639           
  Misses         14       14           
Impacted Files Coverage Δ
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 97.43% <100.00%> (+0.21%) :arrow_up:
...rmat_to_mjcf/sdformat_to_mjcf/converters/sensor.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 590822c...805f8ec. Read the comment docs.