Used right enum namespace

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

This PR https://github.com/gazebosim/sdformat/pull/1029 in SDFormat changes the enum namespace. This PR fixed the enums.

We need to wait for a nightly release

Checklist

• [x] Signed all commits for DCO
• [ ] Added tests
• [ ] Updated documentation (as needed)
• [ ] Updated migration guide (as needed)
• [ ] Consider updating Python bindings (if the library has them)
• [x] codecheck passed (See contributing)
• [x] All tests passed (See test coverage)
• [x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[azeey]

We'll need to trigger the nightly build of SDFormat.

[scpeters]

We'll need to trigger the nightly build of SDFormat.

that build succeeded, but it didn't have an incremented RELEASE_VERSION so it failed to upload:

• https://build.osrfoundation.org/view/ign-garden/job/repository_uploader_packages/26077/

I've started new nightly builds with RELEASE_VERSION == 2

• https://build.osrfoundation.org/view/ign-garden/job/sdformat13-debbuilder/300/
• https://build.osrfoundation.org/view/ign-garden/job/sdformat13-debbuilder/301/

[azeey]

We'll need to trigger the nightly build of SDFormat.

that build succeeded, but it didn't have an incremented RELEASE_VERSION so it failed to upload:

• https://build.osrfoundation.org/view/ign-garden/job/repository_uploader_packages/26077/

I've started new nightly builds with RELEASE_VERSION == 2

• https://build.osrfoundation.org/view/ign-garden/job/sdformat13-debbuilder/300/
• https://build.osrfoundation.org/view/ign-garden/job/sdformat13-debbuilder/301/

hmm, I didn't think it needed it because it would be building from a new commit.

[azeey]

Conflicts

[codecov[bot]]

Codecov Report

Merging #44 (f4b553b) into main (592b2a0) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   97.09%   97.08%   -0.01%     
==========================================
  Files          14       14              
  Lines         482      481       -1     
==========================================
- Hits          468      467       -1     
  Misses         14       14              

Impacted Files	Coverage Δ
...at_to_mjcf/sdformat_to_mjcf/converters/geometry.py	92.06% <ø> (-0.25%)	:arrow_down:
...ormat_to_mjcf/sdformat_to_mjcf/converters/light.py	100.00% <ø> (ø)
...o_sdformat/mjcf_to_sdformat/converters/geometry.py	95.94% <100.00%> (ø)
...ormat_to_mjcf/sdformat_to_mjcf/converters/joint.py	96.92% <100.00%> (-0.05%)	:arrow_down:
...at_to_mjcf/sdformat_to_mjcf/converters/material.py	100.00% <100.00%> (ø)
...ormat_to_mjcf/sdformat_to_mjcf/converters/model.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 592b2a0...f4b553b. Read the comment docs.

[scpeters]

hmm, I didn't think it needed it because it would be building from a new commit.

while the commit hash is embedded in the file name, I believe it isn't used for sorting since it's not guaranteed to be monotonically increasing. I believe the release version needs to be incremented

[azeey]

I think codecov is complaining about removed lines. Doesn't seem like a real decrease in coverage. Will go ahead and merge.