gazebosim / gz-mujoco

27 stars 4 forks source link

MJCF to SDF: Improved inertia #48

Closed ahcorde closed 2 years ago

ahcorde commented 2 years ago

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #48 (bb61d7a) into main (5a6ce8d) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   97.77%   97.79%   +0.02%     
==========================================
  Files          16       16              
  Lines         628      636       +8     
==========================================
+ Hits          614      622       +8     
  Misses         14       14              
Impacted Files Coverage Δ
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a6ce8d...bb61d7a. Read the comment docs.

scpeters commented 2 years ago

I resolved conflicts but am getting a test failure locally

azeey commented 2 years ago

tests are failing.

ahcorde commented 2 years ago

tests are failing.

@azeey Fixed

ahcorde commented 2 years ago

nit: this is a position, not a pose, so I would rename inertia_pose to inertia_position or inertia_pos

@scpeters https://github.com/gazebosim/gz-mujoco/pull/48/commits/55a3dc5d8446b30e2bd8b901a9eb8d3e98c4958a