Closed ahcorde closed 2 years ago
Merging #48 (bb61d7a) into main (5a6ce8d) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 97.77% 97.79% +0.02%
==========================================
Files 16 16
Lines 628 636 +8
==========================================
+ Hits 614 622 +8
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py | 100.00% <100.00%> (ø) |
|
...f_to_sdformat/mjcf_to_sdformat/converters/world.py | 96.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5a6ce8d...bb61d7a. Read the comment docs.
I resolved conflicts but am getting a test failure locally
tests are failing.
tests are failing.
@azeey Fixed
nit: this is a position, not a pose, so I would rename
inertia_pose
toinertia_position
orinertia_pos
@scpeters https://github.com/gazebosim/gz-mujoco/pull/48/commits/55a3dc5d8446b30e2bd8b901a9eb8d3e98c4958a
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.