gazebosim / gz-mujoco

25 stars 4 forks source link

Fix link pose so that it reflects the parent model's pose #52

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

The Model pose was not being reflected on the generated MJCF body's pose. The previous approach was working fine in tests because we bypass pose resolution. An integration test where a full SDFormat file is loaded shows the error.

The issue with the previous approach was the setting link.set_raw_pose does not affect the pose graphs in SDFormat, so consequent pose resolution queries do not contain the new pose set via link.set_raw_pose.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (25426d3) into main (85787a3) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          16       16           
  Lines         589      589           
=======================================
  Hits          575      575           
  Misses         14       14           
Impacted Files Coverage Δ
...format_to_mjcf/sdformat_to_mjcf/converters/link.py 100.00% <100.00%> (ø)
...ormat_to_mjcf/sdformat_to_mjcf/converters/model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85787a3...25426d3. Read the comment docs.