Closed ahcorde closed 2 years ago
Merging #55 (29e7654) into main (590822c) will decrease coverage by
0.43%
. The diff coverage is94.38%
.
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 97.85% 97.41% -0.44%
==========================================
Files 16 17 +1
Lines 653 736 +83
==========================================
+ Hits 639 717 +78
- Misses 14 19 +5
Impacted Files | Coverage Δ | |
---|---|---|
...f_to_sdformat/mjcf_to_sdformat/converters/joint.py | 92.30% <92.30%> (ø) |
|
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py | 100.00% <100.00%> (ø) |
|
...f_to_sdformat/mjcf_to_sdformat/converters/world.py | 97.95% <100.00%> (+0.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 549875a...29e7654. Read the comment docs.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
Build on top of https://github.com/gazebosim/gz-mujoco/pull/43
Add prismatic and revolute joints + defaults
This is the humanoid with all the joints
One limitation that we have right now:
I think this is used in Mujoco to check the values of the 3 axes but in Ignition we can't handle several joint with the same child.
Similar thing is happening in the humanoid models some joints are connect to the same model
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.