gazebosim / gz-mujoco

25 stars 4 forks source link

MJCF 2 SDF: Support prismatic and revolute joints #55

Closed ahcorde closed 2 years ago

ahcorde commented 2 years ago

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Build on top of https://github.com/gazebosim/gz-mujoco/pull/43

Add prismatic and revolute joints + defaults

This is the humanoid with all the joints

Selection_081

One limitation that we have right now:

Similar thing is happening in the humanoid models some joints are connect to the same model

[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [torso] as parent and [lower_waist] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [pelvis] as parent and [right_thigh] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [pelvis] as parent and [right_thigh] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [right_shin] as parent and [right_foot] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [pelvis] as parent and [left_thigh] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [pelvis] as parent and [left_thigh] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [left_shin] as parent and [left_foot] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [torso] as parent and [right_upper_arm] as child, but the child link already has a parent joint of type [RevoluteJoint].
[Err] [SDFFeatures.cc:1024] Asked to create a joint between links [torso] as parent and [left_upper_arm] as child, but the child link already has a parent joint of type [RevoluteJoint].

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (29e7654) into main (590822c) will decrease coverage by 0.43%. The diff coverage is 94.38%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   97.85%   97.41%   -0.44%     
==========================================
  Files          16       17       +1     
  Lines         653      736      +83     
==========================================
+ Hits          639      717      +78     
- Misses         14       19       +5     
Impacted Files Coverage Δ
...f_to_sdformat/mjcf_to_sdformat/converters/joint.py 92.30% <92.30%> (ø)
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 97.95% <100.00%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 549875a...29e7654. Read the comment docs.