gazebosim / gz-mujoco

27 stars 4 forks source link

mjcf -> SDFormat: minor fixes #59

Closed scpeters closed 2 years ago

scpeters commented 2 years ago

🦟 Bug fix

Two minor fixes for things I noticed during code review

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #59 (f1fdece) into main (60f2d21) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          16       16           
  Lines         646      646           
=======================================
  Hits          632      632           
  Misses         14       14           
Impacted Files Coverage Δ
...o_sdformat/mjcf_to_sdformat/converters/geometry.py 95.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60f2d21...f1fdece. Read the comment docs.