gazebosim / gz-mujoco

27 stars 4 forks source link

Add SDFormat to MJCF converter script #6

Closed azeey closed 2 years ago

azeey commented 2 years ago

🎉 New feature

Summary

This contains all the changes in #2, #4, and #5. The goal is to split out the remaining changes into separate smaller PRs.

Test it

See README.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #6 (bd25eb4) into main (a580cce) will increase coverage by 0.88%. The diff coverage is 98.18%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   96.05%   96.94%   +0.88%     
==========================================
  Files          10       11       +1     
  Lines         279      327      +48     
==========================================
+ Hits          268      317      +49     
+ Misses         11       10       -1     
Impacted Files Coverage Δ
sdformat_to_mjcf/sdformat_to_mjcf/cli.py 90.90% <90.90%> (ø)
...ormat_to_mjcf/sdformat_to_mjcf/converters/model.py 100.00% <100.00%> (ø)
...format_to_mjcf/sdformat_to_mjcf/converters/root.py 100.00% <100.00%> (ø)
...format_to_mjcf/sdformat_to_mjcf/sformat_to_mjcf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a580cce...bd25eb4. Read the comment docs.

azeey commented 2 years ago

This is ready for review. Note that #37 is implementing add_world.

azeey commented 2 years ago

conflicts

fixed