gazebosim / gz-mujoco

25 stars 4 forks source link

SDFormat to MJCF: Add conversion for camera sensor #60

Closed azeey closed 2 years ago

azeey commented 2 years ago

🎉 New feature

Toward #16

Summary

It turns out there is not much to convert for cameras since Mujoco cameras are really not sensors. I added a warning just to let the user know that almost none of the sensor parameters are mapped.

Test it

test_add_sensor.py test_add_link.py

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #60 (2457fab) into main (9e0e6e6) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.02%     
==========================================
  Files          16       16              
  Lines         646      653       +7     
==========================================
+ Hits          632      639       +7     
  Misses         14       14              
Impacted Files Coverage Δ
...rmat_to_mjcf/sdformat_to_mjcf/converters/sensor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e0e6e6...2457fab. Read the comment docs.