gazebosim / gz-mujoco

25 stars 4 forks source link

Suggestion to #43: Alternative implementation of MJCF default classes #61

Closed azeey closed 2 years ago

azeey commented 2 years ago

🎉 New feature

Summary

This implements a class that knows how to process and apply MJCF default classes to any given element. The implementation is based on https://github.com/deepmind/mujoco/blob/d7ae7f54338a8ea02c34f4a969722182481eb72b/unity/Runtime/Importer/MjXmlModifiers.cs.

TODO:

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #61 (78a98a7) into ahcorde/mjcf2sdf/geometry_defaults (5256968) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@                          Coverage Diff                           @@
##           ahcorde/mjcf2sdf/geometry_defaults      #61      +/-   ##
======================================================================
- Coverage                               97.92%   97.85%   -0.07%     
======================================================================
  Files                                      16       16              
  Lines                                     674      653      -21     
======================================================================
- Hits                                      660      639      -21     
  Misses                                     14       14              
Impacted Files Coverage Δ
...cf_to_sdformat/mjcf_to_sdformat/converters/link.py 100.00% <100.00%> (ø)
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 97.43% <100.00%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5256968...78a98a7. Read the comment docs.