gazebosim / gz-mujoco

25 stars 4 forks source link

MJCF->SDFormat: Fix sizes for infinite planes #64

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

A size of [0, 0] is interpreted as an infinite plane for the purpose of visualization in Mujoco, but Gazebo treats it a size of 0, so instead, we use a very large size.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (8918249) into main (ab8fd15) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   97.20%   97.22%   +0.01%     
==========================================
  Files          19       19              
  Lines         824      828       +4     
==========================================
+ Hits          801      805       +4     
  Misses         23       23              
Impacted Files Coverage Δ
...o_sdformat/mjcf_to_sdformat/converters/geometry.py 96.15% <100.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab8fd15...8918249. Read the comment docs.