gazebosim / gz-mujoco

25 stars 4 forks source link

SDFormat->MJCF: Use unique names for lights #65

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

Discovered in a local roundtrip test on humanoid.xml

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #65 (22099f2) into main (043ad60) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          19       19           
  Lines         828      828           
=======================================
  Hits          805      805           
  Misses         23       23           
Impacted Files Coverage Δ
...ormat_to_mjcf/sdformat_to_mjcf/converters/light.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 043ad60...22099f2. Read the comment docs.