gazebosim / gz-mujoco

27 stars 4 forks source link

Fix default compiler.angle value and refactor get_pose_from_mjcf #68

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

The default value of compiler.angle is "degree" for MJCF (https://mujoco.readthedocs.io/en/latest/XMLreference.html#compiler). This also refactors get_pose_from_mjcf so that the compiler option is always checked when extracting poses from MJCF elements.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #68 (bdc9b28) into main (8aabd71) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          19       19           
  Lines         828      828           
=======================================
  Hits          805      805           
  Misses         23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aabd71...bdc9b28. Read the comment docs.