Closed azeey closed 2 years ago
Merging #71 (de28e28) into main (5c88830) will increase coverage by
1.40%
. The diff coverage is93.75%
.
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 93.75% 95.16% +1.40%
==========================================
Files 24 24
Lines 1073 1096 +23
==========================================
+ Hits 1006 1043 +37
+ Misses 67 53 -14
Impacted Files | Coverage Ξ | |
---|---|---|
sdformat_mjcf/src/sdformat_mjcf/utils/sdf_utils.py | 90.17% <71.42%> (-1.34%) |
:arrow_down: |
...ormat_mjcf/mjcf_to_sdformat/converters/geometry.py | 96.55% <100.00%> (+0.39%) |
:arrow_up: |
...ormat_mjcf/mjcf_to_sdformat/converters/material.py | 95.00% <100.00%> (+3.69%) |
:arrow_up: |
...sdformat_mjcf/mjcf_to_sdformat/mjcf_to_sdformat.py | 100.00% <100.00%> (+100.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 5c88830...de28e28. Read the comment docs.
Looks like the codecov/patch is mainly complaining about removed lines. Will go ahead and merge
π New feature
Summary
In addition to the conversion, meshes are exported to a
meshes
subdirectory inside the output directory (the parent directory of the output file).710dc34af9d918a3cd84842cce54b4728ad99633 refactors
test_add_mjcf_geometry_to_sdf.py
to avoid duplication.Test it
test_add_mjcf_geometry_to_sdf.py
test_mjcf_to_sdformat.py
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.