Closed scpeters closed 2 years ago
Merging #73 (78e4ad0) into main (7d75e16) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 19 19
Lines 828 829 +1
=======================================
+ Hits 805 806 +1
Misses 23 23
Impacted Files | Coverage Δ | |
---|---|---|
...f_to_sdformat/mjcf_to_sdformat/converters/world.py | 98.43% <100.00%> (+0.02%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7d75e16...78e4ad0. Read the comment docs.
🦟 Bug fix
Allows contact between links after converting from MJCF -> SDFormat
Summary
When converting from MJCF to SDFormat, all links are placed in the same model. With this arrangement, no contacts are possible unless
//model/self_collide
is set to True. Since it defaults to False, set it to True explicitly.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.