gazebosim / gz-mujoco

27 stars 4 forks source link

Prevent Visual geoms from colliding with other geoms #75

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

Currently, even though we set group numbers on collision and visual geoms to display only the visuals, they still take part in the collision detection process and collide with any other geom. Setting the contype and conaffinity to 0 will ensure that they don't collide with any other geom.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (a736caa) into main (481ead3) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          19       19           
  Lines         862      864    +2     
=======================================
+ Hits          839      841    +2     
  Misses         23       23           
Impacted Files Coverage Δ
...at_to_mjcf/sdformat_to_mjcf/converters/geometry.py 92.30% <100.00%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 481ead3...a736caa. Read the comment docs.