gazebosim / gz-mujoco

27 stars 4 forks source link

SDFormat to MJCF: Use a unique name for ball joints #80

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

Some joint types already use unique names, but we missed ball joints.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@55370c2). Click here to learn what that means. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   95.16%           
=======================================
  Files           ?       24           
  Lines           ?     1097           
  Branches        ?        0           
=======================================
  Hits            ?     1044           
  Misses          ?       53           
  Partials        ?        0           
Impacted Files Coverage Δ
...sdformat_mjcf/sdformat_to_mjcf/converters/joint.py 97.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55370c2...910d0fb. Read the comment docs.