gazebosim / gz-mujoco

28 stars 4 forks source link

MJCF to SDFormat: Remove duplicate light added to the world #82

Closed azeey closed 2 years ago

azeey commented 2 years ago

🦟 Bug fix

Summary

When there is a light directly under <worldbody>, we currently create a light in <world> and in the static model. This PR removes the light in <world>. We could remove the one in the static model, but this seemed like the easier option.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #82 (8f07ab0) into main (b65298f) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   95.16%   95.14%   -0.03%     
==========================================
  Files          24       24              
  Lines        1097     1092       -5     
==========================================
- Hits         1044     1039       -5     
  Misses         53       53              
Impacted Files Coverage Δ
...sdformat_mjcf/mjcf_to_sdformat/converters/world.py 98.63% <ø> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b65298f...8f07ab0. Read the comment docs.