Closed azeey closed 2 years ago
Merging #83 (95a0875) into main (8e199b5) will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 95.14% 95.17% +0.03%
==========================================
Files 24 24
Lines 1092 1099 +7
==========================================
+ Hits 1039 1046 +7
Misses 53 53
Impacted Files | Coverage Δ | |
---|---|---|
...sdformat_mjcf/mjcf_to_sdformat/converters/light.py | 100.00% <100.00%> (ø) |
|
...ormat_mjcf/mjcf_to_sdformat/converters/material.py | 95.45% <100.00%> (+0.45%) |
:arrow_up: |
sdformat_mjcf/src/sdformat_mjcf/utils/sdf_utils.py | 90.51% <100.00%> (+0.33%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9a4f4e6...95a0875. Read the comment docs.
🦟 Bug fix
Summary
For the following mjcf file,
Mujoco displays:
And before the fix, gz-sim displays:
After this PR, gz-sim displays:
With exponent set to 10, Mujoco displays:
Before the fix, gz-sim displays the same image as before. After this PR, it displays:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸