Closed azeey closed 2 years ago
Merging #84 (2750fba) into main (8e199b5) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 95.14% 95.16% +0.01%
==========================================
Files 24 24
Lines 1092 1096 +4
==========================================
+ Hits 1039 1043 +4
Misses 53 53
Impacted Files | Coverage Δ | |
---|---|---|
...ormat_mjcf/mjcf_to_sdformat/converters/material.py | 95.45% <100.00%> (+0.45%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8e199b5...2750fba. Read the comment docs.
🦟 Bug fix
Summary
The default rgba value of a geom is "0.5 0.5 0.5 1" (https://mujoco.readthedocs.io/en/latest/XMLreference.html#body-geom) For the following MJCF file
Mujoco displays:![image](https://user-images.githubusercontent.com/206116/173930254-8ddf7e88-de33-4d3d-83ee-0a5a5d65cc71.png)
Before this PR, gz-sim displays![image](https://user-images.githubusercontent.com/206116/173930096-24dc0da1-75e8-4370-b690-ae72bd03f124.png)
After this PR, gz-sim displays![image](https://user-images.githubusercontent.com/206116/173930166-9cece2e2-feb0-47bb-afee-fd9815f7e585.png)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.