gazebosim / gz-mujoco

27 stars 4 forks source link

mjcf->sdformat sliding friction #86

Closed scpeters closed 2 years ago

scpeters commented 2 years ago

🎉 New feature

Follow-up to https://github.com/gazebosim/gz-mujoco/pull/70

Summary

This supports translation of sliding friction parameters from MJCF to SDFormat, the reverse of #70. It requires https://github.com/gazebosim/sdformat/pull/1049 and will remain in draft state until that is merged.

Test it

sdformat2mjcf friction_demo.sdf friction_demo_1.xml
mjcf2sdformat friction_demo_1.xml friction_demo_2.sdf

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (359552a) into main (9ae088d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files          24       24           
  Lines        1177     1179    +2     
=======================================
+ Hits         1120     1122    +2     
  Misses         57       57           
Impacted Files Coverage Δ
...ormat_mjcf/mjcf_to_sdformat/converters/geometry.py 96.84% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ae088d...359552a. Read the comment docs.

azeey commented 2 years ago

Fixed test error in https://github.com/gazebosim/gz-mujoco/pull/86/commits/359552a25158807c21f883de7b78251d21fb983d