Closed azeey closed 2 years ago
Merging #95 (71b4688) into main (952e032) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 95.11% 95.12%
=======================================
Files 24 24
Lines 1168 1170 +2
=======================================
+ Hits 1111 1113 +2
Misses 57 57
Impacted Files | Coverage Δ | |
---|---|---|
...ormat_mjcf/mjcf_to_sdformat/converters/geometry.py | 96.77% <100.00%> (+0.07%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 952e032...71b4688. Read the comment docs.
🦟 Bug fix
Summary
While trying to convert
dm_control/dm_control/suite/dog.xml
I noticed that we are not handling geoms without atype
attribute. The default value of geom types issphere
according to the MJCF docs.Apparently it's also possible to specify
geom[@mesh]
without settingtype
, and this PR also addresses that.Finally, we were not checking if
geom[@scale]
was set when processing meshes. This PR applies the default scale if the attribute is not set.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.