gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
63 stars 38 forks source link

CI workflow: use 22.04 for codecheck, coverage #578

Closed scpeters closed 7 months ago

scpeters commented 7 months ago

🎉 New feature

Improves coverage with bullet-featherstone

Summary

In #574, some functionality is being added that depends on a version of bullet that is not available on 20.04 but is available on 22.04, macOS and windows (see https://github.com/gazebosim/gz-physics/pull/574#discussion_r1397703321). Some ifdefs are being added to support compilation on 20.04, but computing code coverage on 20.04 will be incomplete. This changes the code coverage and codecheck platforms from 20.04 to 22.04, and CI is still 🟢, so it seems like a safe change.

Test it

Observer results of GitHub workflow.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e58f88) 77.77% compared to head (50b4baa) 78.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics6 #578 +/- ## =============================================== + Coverage 77.77% 78.68% +0.90% =============================================== Files 143 140 -3 Lines 7295 7648 +353 =============================================== + Hits 5674 6018 +344 - Misses 1621 1630 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.