Closed scpeters closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5e58f88
) 77.77% compared to head (50b4baa
) 78.68%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎉 New feature
Improves coverage with bullet-featherstone
Summary
In #574, some functionality is being added that depends on a version of bullet that is not available on 20.04 but is available on 22.04, macOS and windows (see https://github.com/gazebosim/gz-physics/pull/574#discussion_r1397703321). Some ifdefs are being added to support compilation on 20.04, but computing code coverage on 20.04 will be incomplete. This changes the code coverage and codecheck platforms from 20.04 to 22.04, and CI is still 🟢, so it seems like a safe change.
Test it
Observer results of GitHub workflow.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.