gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
65 stars 40 forks source link

bullet-featherstone: Set collision spinning friction #579

Closed iche033 closed 10 months ago

iche033 commented 10 months ago

🦟 Bug fix

Summary

Set collision spinning friction using on sdf's torsional coefficient value. If not specified in sdf, the default value of 1.0 is used.

When 2 boxes penetrate, bullet pushes them apart. Without the spinning friction set, the boxes will continue to spin indefinitely or until it collides with another object. This PR sets the spinning friction to prevent this from happening

Before: bullet_no_spinning_friction

After: bullet_spinning_friction

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (af58fa5) 78.68% compared to head (c98cbdf) 78.59%.

Files Patch % Lines
bullet-featherstone/src/SDFFeatures.cc 58.33% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics6 #579 +/- ## =============================================== - Coverage 78.68% 78.59% -0.09% =============================================== Files 140 140 Lines 7648 7654 +6 =============================================== - Hits 6018 6016 -2 - Misses 1630 1638 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.