Closed iche033 closed 10 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
af58fa5
) 78.68% compared to head (c98cbdf
) 78.59%.
Files | Patch % | Lines |
---|---|---|
bullet-featherstone/src/SDFFeatures.cc | 58.33% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🦟 Bug fix
Summary
Set collision spinning friction using on sdf's torsional coefficient value. If not specified in sdf, the default value of 1.0 is used.
When 2 boxes penetrate, bullet pushes them apart. Without the spinning friction set, the boxes will continue to spin indefinitely or until it collides with another object. This PR sets the spinning friction to prevent this from happening
Before:
After:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.