gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
65 stars 40 forks source link

Garden test cleanup #587

Closed mjcarroll closed 8 months ago

mjcarroll commented 8 months ago

Split from #513 for easier review.

This cleans up physics tests in a few ways:

mjcarroll commented 8 months ago

A question here (maybe for @scpeters @ahcorde). There are worlds/sdf files that are spread out among the various implementations. Can these be deduplicated/consolidated?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5367620) 78.64% compared to head (e84feed) 78.47%.

:exclamation: Current head e84feed differs from pull request most recent head 1c806fd. Consider uploading reports for the commit 1c806fd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics6 #587 +/- ## =============================================== - Coverage 78.64% 78.47% -0.17% =============================================== Files 141 139 -2 Lines 7713 7611 -102 =============================================== - Hits 6066 5973 -93 + Misses 1647 1638 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mjcarroll commented 8 months ago

@scpeters I have removed anything that was duplicated (or closely duplicated). This required some small changes in the tpe tests to match the common world files.